Overhaul build process with setuptools_scm and written version file #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 89.23% 89.23% -0.01%
==========================================
Files 23 23
Lines 2537 2536 -1
==========================================
- Hits 2264 2263 -1
Misses 273 273
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mraspaud
approved these changes
Sep 20, 2023
Co-authored-by: Martin Raspaud <[email protected]>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various issues encountered with new versions of
setuptools_scm. Pyspectral was depending on a deprecated packagesetuptools_scm_git_archivewhose features are now included upstream insetuptools_scm.Additionally I removed a hack in
setup.pythat was copied from satpy to tell setuptools_scm to not copy every file that git knows about. This has been worked around in recent versions of setuptools_scm by allowing you to exclude files from your MANIFEST.in. However, I find it very annoying to have to exclude everything that might be unnecessary so instead I exclude everything and then add what we want back in.I removed all the mocking in the docs and just added those dependencies to the RTD environment.
I also switched from a dynamic version loading that was using
pkg_resourcesto a configuration wheresetuptools_scmwrites apyspectral/version.pyfile. This is better for import performance and avoids the usage of the deprecatedpkg_resourcespackage. This package is used elsewhere in pyspectral and will need to be replaced with importlib.resources (I think that's the name) so FYI @adybbroe.Let me know if you have any questions. We need this merged ASAP so that other packages can install pyspectral from source again.
pytest pyspectralflake8 pyspectralAUTHORS.mdif not there already